Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

use dash loosen-testing-reqs branch and fix linting #857

Merged
merged 3 commits into from
Dec 17, 2020
Merged

use dash loosen-testing-reqs branch and fix linting #857

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ddffde
use dash loosen-testing-reqs branch and fix linting
alexcjohnson Dec 17, 2020
e3051da
prohibit xlrd v2, so xlsx will still work
alexcjohnson Dec 17, 2020
e6f57fb
back to dev branch of dash
alexcjohnson Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
python -m venv venv || virtualenv venv
. venv/bin/activate
pip install -r dev-requirements.txt --quiet
git clone --depth 1 [email protected]:plotly/dash.git dash-main
git clone --depth 1 -b loosen-testing-reqs [email protected]:plotly/dash.git dash-main
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can revert these branches and merge this PR even before plotly/dash#1506 merges, because the changes here are fine with dash@dev

pip install -e ./dash-main[dev,testing] --quiet
cd dash-main/dash-renderer && npm ci && npm run build && pip install -e . && cd ./../..

Expand Down Expand Up @@ -185,7 +185,7 @@ jobs:
command: |
. venv/bin/activate
pip install -r dev-requirements.txt --quiet
pip install --progress-bar off -e git+https://github.com/plotly/dash.git@dev#egg=dash[dev,testing]
pip install --progress-bar off -e git+https://github.com/plotly/dash.git@loosen-testing-reqs#egg=dash[dev,testing]

- run:
name: Run eslint
Expand Down
6 changes: 3 additions & 3 deletions dash_table_base/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@

import dash as _dash

from ._imports_ import * # noqa: F401, F403
from ._imports_ import __all__

if not hasattr(_dash, '__plotly_dash') and not hasattr(_dash, 'development'):
print(
"Dash was not successfully imported. "
Expand All @@ -18,6 +15,9 @@
)
_sys.exit(1)

from ._imports_ import * # noqa: E402, F401, F403
from ._imports_ import __all__ # noqa: E402
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test above needs to happen before these imports or it's useless, because the components will try to use dash.development.


_basepath = _os.path.dirname(__file__)
_filepath = _os.path.abspath(_os.path.join(_basepath, "package-info.json"))
with open(_filepath) as f:
Expand Down