Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

Add fallback copy handler. #725

Closed
wants to merge 4 commits into from
Closed

Add fallback copy handler. #725

wants to merge 4 commits into from

Conversation

shammamah-zz
Copy link
Contributor

@shammamah-zz shammamah-zz commented Mar 23, 2020

About

Closes #526

Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shammamah

  • Missing changelog entry
  • We've discussed this IRL but can you explain here the difficulties creating a test case to lock this behavior?

@shammamah-zz
Copy link
Contributor Author

We've discussed this IRL but can you explain here the difficulties creating a test case to lock this behavior?

This behaviour wasn't picked up on earlier because our existing copy/paste tests have all passed. The current tests all have to do with copying/pasting from the table to the table itself. This error has shown up upon copy from the table to paste in an external spreadsheet.

@Marc-Andre-Rivet
Copy link
Contributor

This error has shown up upon copy from the table to paste in an external spreadsheet.

In that case, might be possible to test this by copying from the table to an input in the same page?

@shammamah-zz shammamah-zz marked this pull request as ready for review March 27, 2020 17:59
@Marc-Andre-Rivet
Copy link
Contributor

Superseded by #728

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy/paste does not work in certain situations
2 participants