This repository was archived by the owner on Jun 4, 2024. It is now read-only.
Issue 611 - Hidden columns on copy/paste #621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new clipboard tests
Marc-Andre-Rivet
commented
Oct 9, 2019
| newColumns | ||
| ); | ||
|
|
||
| newVisibleColumns = R.concat(newVisibleColumns, _newColumns); |
There was a problem hiding this comment.
When new columns are created, they are appended after the last visible column. Both visible and "all" columns are updated to both (1) handle the copy/paste below and (2) the columns update correctly.
There was a problem hiding this comment.
hmm OK - I might have added the new columns after trailing hidden columns as well, but it's probably impossible to declare one way objectively better than the other. This is fine.
Marc-Andre-Rivet
commented
Oct 9, 2019
| expect(Object.entries(res.data[0]).length).to.equal(3); | ||
| expect(res.columns.length).to.equal(3); | ||
| expect(res.columns[0].id).to.equal('c1'); | ||
| expect(res.columns[1].id).to.equal('c2'); |
There was a problem hiding this comment.
Check that all columns are present and in the right order after a copy/paste operation involving hidden columns
alexcjohnson
approved these changes
Oct 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #611
Similarly to what's being done elsewhere, the clipboard needs to take into consideration both the visible columns and all the available columns when handling a copy/paste operation.
The last visible column is used to determine placement and whether new columns are required, all columns are used to determine the final set of columns if new ones are needed and their final placement based on visible ones.
Added two tests to the clipboard to check the behavior when there are hidden columns.