This repository was archived by the owner on Jun 3, 2024. It is now read-only.
dcc.Location props fix for callbacks #774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HammadTheOne
requested review from
alexcjohnson and
Marc-Andre-Rivet
as code owners
|
Nice! supersedes community PR #765 - take a look at the app there as a test case. |
|
Hi, thanks for this! We found this bug while developing a multi-page app with one part listening for the pathname changes, and one part for the search-changes, resulting in double callbacks for the search callback. In what version do you expect this fix to be included? We can then remove a custom component (and an entire step in our DDS deployment script) |
|
@AHMatsWillemsen this fix is expected to be included in the next Dash version (1.10) |
Marc-Andre-Rivet
approved these changes
Mar 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #769,
dcc.Locationwas firing callbacks for thepathnamewhen thehrefwas changed. This behaviour carried over to all props, includinghashandsearch. This PR fixes that behaviour by adding in conditionals to check whether the new value is different from the previous one.To Do: