This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Remove artifacts from dev
#659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove build artifacts - two step generation for now
Marc-Andre-Rivet
requested review from
alexcjohnson and
byronz
as code owners
byronz
reviewed
Sep 25, 2019
.circleci/config.yml
Outdated
| - image: percyio/agent | ||
| steps: | ||
| - run: percy finalize --all | ||
| 'percy-finalize': |
There was a problem hiding this comment.
does this file just get prettier? hard to tell from the diff the real change
byronz
reviewed
Sep 25, 2019
.circleci/config.yml
Outdated
| # build main dash | ||
| git clone --depth 1 https://github.com/plotly/dash.git dash-main | ||
| cd dash-main && pip install -e .[dev,testing] && python setup.py sdist && mv dist/* ../packages/ | ||
| cd dash-main && pip install -e .[dev,testing] --quiet && python setup.py sdist && mv dist/* ../packages/ |
There was a problem hiding this comment.
I think our intention is to mute the progress bar, --progress-bar off
at least for now, we need to check the pip install logs from time to time
byronz
approved these changes
Sep 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as dash-table plotly/dash-table#603