Skip to content

Conversation

neelasha23
Copy link

@neelasha23 neelasha23 commented Jun 7, 2023

Describe your changes

Snowflake integration guide

Issue number

Closes #384

Checklist before requesting a review


📚 Documentation preview 📚: https://jupysql--591.org.readthedocs.build/en/591/

@neelasha23 neelasha23 requested a review from edublancas as a code owner June 7, 2023 17:51
@neelasha23
Copy link
Author

I have added the guide, but the build is failing because of the dummy credentials. Initially I run the entire notebook, and after all the cell outputs were generated, I changed the connection parameters to dummy values:

engine = create_engine(
    URL(
        drivername="driver",
        user="user",
        password="password",
        account="account",
        database="database",
        role="role",
        schema="schema",
        warehouse="warehouse",
    )
)

However, the cells still try to execute and fails at %sql engine.

Is there any other approach? Should we save these values as readthedocs public env variables and try to read those in the notebook? It would be read like ${env_variable_name}, but this is specific to readthedocs and wont work on notebooks.

@edublancas

@edublancas
Copy link

we can do the same that we've done for other tutorials: we run them locally, upload them as ipynb and then configure readthedocs to skip its execution - we should not store snowflake credentials on readthedocs

Copy link

@edublancas edublancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comment above

@edublancas
Copy link

btw, hide the connection string. instructions here: https://jupysql.ploomber.io/en/latest/howto.html#hide-connection-string

alias

Review comments
@edublancas edublancas merged commit e882037 into ploomber:master Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a snowflake guide to integrations section
2 participants