Stop setting BUNDLE_PATH #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't dig into why BUNDLE_PATH was being overridden, but I'm fairly confident it shouldn't be. It appears to override the bundler configuration, breaking things. It's not uncommon for users to set `BUNDLE_PATH` in their `$HOME/.bundle/config` to something like "vendor/bundle" in order to get their project gems installed into a directory within the project. This is even encouraged by the bundler docs. Setting BUNDLE_PATH to the gem home in the env appears to break this. Bundler commands run from within emacs are unable to find any of the gems that are installed locally to my projects, I assume because they are searching in the GEM_HOME instead of the project local path.
|
Thanks. The idea for chruby.el is that it copies the behavior of chruby (https://github.com/postmodern/chruby), but apparently chruby also doesn't set BUNDLE_PATH, so not sure where that came from. Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't dig into why BUNDLE_PATH was being overridden, but I'm fairly confident
it shouldn't be. It appears to override the bundler configuration, breaking
things.
It's not uncommon for users to set
BUNDLE_PATHin their$HOME/.bundle/configto something like "vendor/bundle" in order to get their project gems installed
into a directory within the project. This is even encouraged by the bundler
docs.
Setting BUNDLE_PATH to the gem home in the env appears to break this. Bundler
commands run from within emacs are unable to find any of the gems that are
installed locally to my projects, I assume because they are searching in the
GEM_HOME instead of the project local path.