Skip to content

Conversation

@mdnfiras
Copy link

This solve an issue described in vitessio/vitess/issues/19054 and solved in vitessio/vitess/pull/19053.

I'm reimplementing this here to sync things up and get a better signal as to whether or not there are any unexpected/unintended side effects.

cc @mattlord

@frouioui
Copy link
Member

Hey! The main operator yaml file in the test is not changing in this PR despite the changes to the deploy folder. Can you make sure to run:

 kustomize build ./deploy > build/_output/operator.yaml

And then copy this file into test/endtoend/operator/operator-latest.yaml (making sure no new indentations etc are added).

@mdnfiras
Copy link
Author

I'm not sure what you mean by making sure no new indentations etc are added: indentations are actually missing, and it looks like I made a lot of changes in the git diff if I don't add the missing indentations.

Also the deployment's spec.securityContext is missing in kustomize build ./deploy output, and there are few other differences unrelated to my changes. Should I add the missing indentations so we can see clearly what actually changed in the git diff?

@mdnfiras
Copy link
Author

I updated the commit to ensure only equivalent changes are made in test/endtoend/operator/operator-latest.yaml

@mdnfiras
Copy link
Author

I see backup related jobs are failing, and they're using the example namespace. I'm restoring the rbac resources in the example namespace but I'm moving their definitions to test/endtoend/operator/101_initial_cluster_backup.yaml and test/endtoend/operator/101_initial_cluster_backup_schedule.yaml files.

@mdnfiras
Copy link
Author

Anything I need to do to get the Integration Test and Unit Test to run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants