Reformat the repository with black 22.12.0#95
Closed
ferringb wants to merge 2 commits intopkgcore:masterfrom
Closed
Reformat the repository with black 22.12.0#95ferringb wants to merge 2 commits intopkgcore:masterfrom
ferringb wants to merge 2 commits intopkgcore:masterfrom
Conversation
This can be activate (per repo) via: git config blame.ignoreRevsFile .git-blame-ignore-revs
Codecov ReportBase: 59.13% // Head: 59.13% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #95 +/- ##
=======================================
Coverage 59.13% 59.13%
=======================================
Files 58 58
Lines 6774 6774
Branches 1410 1410
=======================================
Hits 4006 4006
Misses 2529 2529
Partials 239 239
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
arthurzam
approved these changes
Dec 25, 2022
Member
arthurzam
left a comment
arthurzam
left a comment
There was a problem hiding this comment.
After some tests, the default by black seems fine enough for me. Let's go with it. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally, add a .git-blame-ignore-revs so
git blamedoesn't attribute all of this to myself. Once that file is in there I'll go through the history and add a few more since snakeoil history is long, and code has shuffled enough the original commit documentation isn't easily reachable.Note: if folks don't like the formatting of this, the PR can be punted. Black can also be tuned as needed, this is just me getting the ball rolling.