Issue 305 client write #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puellanivis
approved these changes
Oct 7, 2019
Collaborator
puellanivis
left a comment
puellanivis
left a comment
There was a problem hiding this comment.
Simple fix, simple PR. :)
| // already exists. If successful, methods on the returned File can be used for | ||
| // I/O; the associated file descriptor has mode O_RDWR. If you need more | ||
| // control over the flags/mode used to open the file see client.OpenFile. | ||
| // Note that some SFTP servers (eg. AWS Transfer) do not support opening files |
Collaborator
There was a problem hiding this comment.
I’d probably recommend a paragraph break here.
Need to get StatusError.Code (uint32) converted to fxerr type so you can compare it to public (exported) ErrSSHFx[..] error types. This adds a new method, FxCode(), to the StatusError objects to handle this case. Did this vs trying to change types of existing fields to not break backwards compatibility.
eikenb
force-pushed
the
issue-305-client-write
branch
from
1db881b to
c732bf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #305