Skip to content

Conversation

@emersion
Copy link
Contributor

These are internal V1 details, users of this package shouldn't need
them.

Closes: #29

These are internal V1 details, users of this package shouldn't need
them.

Closes: pires#29
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.222% when pulling 1a07500 on emersion:unexport-internal into fbefd10 on pires:master.

@emersion
Copy link
Contributor Author

Notes:

  • I wonder if we should unexport SplitTLVs too. Is there a case where users would get raw TLVs and want to split them?
  • The SIGV1/SIGV2 variables are left exported because some users might want to manually recognize PROXY headers.

@pires
Copy link
Owner

pires commented Sep 11, 2020

* I wonder if we should unexport `SplitTLVs` too. Is there a case where users would get raw TLVs and want to split them?

There are cases, yes. One example is https://github.com/pires/go-proxyproto/blob/master/tlvparse/ssl.go#L96. Users may have their own code that requires this.

* The `SIGV1`/`SIGV2` variables are left exported because some users might want to manually recognize PROXY headers.

Yep!

Copy link
Owner

@pires pires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution.

@pires pires merged commit 1bb4fdb into pires:master Sep 11, 2020
@emersion emersion deleted the unexport-internal branch September 11, 2020 10:04
@emersion
Copy link
Contributor Author

Users may have their own code that requires this.

Ah, I see, makes sense then!

@pires pires added this to the 0.2.0 milestone Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop exporting internal protocol details

3 participants