v2: drop unnecessary io.LimitReader in parseVersion2 #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binary.Read always reads exactly 2 bytes when decoding a uint16.
pires
approved these changes
Feb 5, 2026
Owner
pires
left a comment
pires
left a comment
There was a problem hiding this comment.
Nice one <3
Avoids allocating the io.LimitedReader on every connection, and now reads directly from the bufio.Reader (which implements io.ByteReader), allowing for potentially faster single-byte reads if binary.Read takes the optimized path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binary.Read always reads exactly 2 bytes when decoding a uint16.