Skip to content

Conversation

@pires
Copy link
Owner

@pires pires commented Jan 20, 2026

@gearnode (author of related #132), @kmala (author of related #108), and @emersion (a much appreciated contributor), would you be so kind as to review?

@coveralls
Copy link

coveralls commented Jan 20, 2026

Coverage Status

coverage: 94.784% (+0.6%) from 94.203%
when pulling 051dc5a on pires/feat/replace_policyfunc_with_connpolicyfunc
into 6dc9050 on main.

@pires pires force-pushed the pires/feat/replace_policyfunc_with_connpolicyfunc branch 2 times, most recently from 2adaa6e to 8d643cf Compare January 20, 2026 11:17
@pires pires force-pushed the pires/feat/replace_policyfunc_with_connpolicyfunc branch from 8d643cf to 051dc5a Compare January 20, 2026 11:22
@pires
Copy link
Owner Author

pires commented Jan 20, 2026

Had to force-push changes to make sure new code paths are covered.

Copy link
Contributor

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kmala
Copy link
Contributor

kmala commented Jan 20, 2026

/lgtm

@pires pires merged commit 1542a61 into main Jan 20, 2026
12 checks passed
@pires pires deleted the pires/feat/replace_policyfunc_with_connpolicyfunc branch January 20, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants