-
-
Notifications
You must be signed in to change notification settings - Fork 126
ci: use local Go toolchain and downgrade Go version #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pires
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton!
|
Somehow, the linter is asking for |
|
I'll check this |
The GitHub Actions workflow defines:
```yaml
strategy:
matrix:
go: ['1.23', '1.24']
```
However, the `1.23` job still ends up running Go `1.24`. By default,
`actions/setup-go` leaves `GOTOOLCHAIN=auto`, causing go itself to fetch the
version specified in `go.mod` instead instead of sticking to exactly `1.23`.
This led to a false positive in CI: it appeared as if the matrix was testing
Go `1.23`, when in reality all jobs were using Go `1.24`.
To fix this, we need to force the use of the local Go toolchain in the CI test
workflow to ensure the use of the locally installed Go version and avoid
automatic downloads by `setup-go`.
Also downgrades the Go version in `go.mod` from `1.24` to `1.23` to ensure
compatibility with environments that do not yet support Go `1.24`.
Fixes pires#126
|
So it seems the sums for the deps change depending on the Go version being used, am I reading the |
Yep, even if |
|
Would you mind tagging a release wit this change? |
|
@pkaeding a new release |
The GitHub Actions workflow defines:
However, the
1.23job still ends up running Go1.24. By default,actions/setup-goleavesGOTOOLCHAIN=auto, causing go itself to fetch the version specified ingo.modinstead instead of sticking to exactly1.23.This led to a false positive in CI: it appeared as if the matrix was testing Go
1.23, when in reality all jobs were using Go1.24.To fix this, we need to force the use of the local Go toolchain in the CI test workflow to ensure the use of the locally installed Go version and avoid automatic downloads by
setup-go.Also downgrades the Go version in
go.modfrom1.24to1.23to ensure compatibility with environments that do not yet support Go1.24.Fixes #126