Add an helper for proxied HTTP/2 #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
force-pushed
the
h2
branch
5 times, most recently
from
a418627 to
e3a3503
Compare
pires
reviewed
Sep 7, 2023
Owner
pires
left a comment
pires
left a comment
There was a problem hiding this comment.
LGTM but would you be so kind to document the code a little more? It would definitely help reviewing, and enrich our API docs.
The standard library's http.Server supports HTTP/2, but only for tls.Conn. This doesn't work when serving connections behind a reverse proxy which terminates TLS and uses the PROXY protocol. Supporting this requires some glue code, which the new helper provides. The example was tested with tlstunnel. Closes: pires#90
Contributor
Author
|
Hopefully this addresses your comments. Let me know if something is still unclear. |
Owner
|
Thanks a ton, @emersion 🙇🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard library's http.Server supports HTTP/2, but only for tls.Conn. This doesn't work when serving connections behind a reverse proxy which terminates TLS and uses the PROXY protocol.
Supporting this requires some glue code, which the new helper provides.
The example was tested with tlstunnel.
Closes: #90