Skip to content

Regenerate core from 2025-04 #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 23, 2025
Merged

Conversation

austin-denoble
Copy link
Contributor

@austin-denoble austin-denoble commented Apr 22, 2025

Problem

We need to regenerate the core OpenAPI modules for the upcoming 2025-04 release.

Solution

  • Regenerate core off of 2025-04.
  • Resolve a few minor TypeScript compile errors in the Assistant actions (we needed to use as <Type>).
  • This PR also includes a lot of integration test cleanup. Most of it is tweaking things to attempt to resolve the weird hangs we get from jest after successful runs. Primarily, I updated some of our error validation, upgraded jest deps to the latest version, and am now passing --forceExit when running tests with jest. There's follow up work to be done here to better clean up the integration suite in the client more generally.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

CI - unit tests / integration tests / external app tests


@austin-denoble austin-denoble changed the base branch from main to 2025-04 April 22, 2025 01:50
@austin-denoble austin-denoble merged commit 8372ce6 into 2025-04 Apr 23, 2025
30 checks passed
@austin-denoble austin-denoble deleted the adenoble/generate-2025-04-base branch April 23, 2025 18:52
austin-denoble added a commit that referenced this pull request Apr 23, 2025
We need to regenerate the core OpenAPI modules for the upcoming
`2025-04` release.

- Regenerate core off of 2025-04.
- Resolve a few minor TypeScript compile errors in the Assistant actions
(we needed to use `as <Type>`).
- This PR also includes a lot of integration test cleanup. Most of it is
tweaking things to attempt to resolve the weird hangs we get from jest
after successful runs. Primarily, I updated some of our error
validation, upgraded jest deps to the latest version, and am now passing
`--forceExit` when running tests with jest. There's follow up work to be
done here to better clean up the integration suite in the client more
generally.

- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
- [ ] Infrastructure change (CI configs, etc)
- [ ] Non-code change (docs, etc)
- [ ] None of the above: (explain here)

CI - unit tests / integration tests / external app tests
@austin-denoble austin-denoble mentioned this pull request May 9, 2025
7 tasks
austin-denoble added a commit that referenced this pull request May 9, 2025
We need to regenerate the core OpenAPI modules for the upcoming
`2025-04` release.

- Regenerate core off of 2025-04.
- Resolve a few minor TypeScript compile errors in the Assistant actions
(we needed to use `as <Type>`).
- This PR also includes a lot of integration test cleanup. Most of it is
tweaking things to attempt to resolve the weird hangs we get from jest
after successful runs. Primarily, I updated some of our error
validation, upgraded jest deps to the latest version, and am now passing
`--forceExit` when running tests with jest. There's follow up work to be
done here to better clean up the integration suite in the client more
generally.

- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
- [ ] Infrastructure change (CI configs, etc)
- [ ] Non-code change (docs, etc)
- [ ] None of the above: (explain here)

CI - unit tests / integration tests / external app tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant