Skip to content

Remove EmbeddingsList custom class #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2025
Merged

Conversation

austin-denoble
Copy link
Contributor

@austin-denoble austin-denoble commented Feb 20, 2025

Problem

The EmbeddingsList class was extremely complicated, and was written only to truncate lengthy output to the console for demonstration purposes.

The class was incorrectly extending Array<>, and mangling the data we were getting back from embed calls that included sparse details.

Solution

Remove the custom EmbeddingsList wrapper and tests and use the interface from the generated core. This means we'll actually get back what we're expecting, and we remove a complex, unwieldy chunk of code.

Before After
Screenshot 2025-02-19 at 8 14 54 PM Screenshot 2025-02-19 at 8 10 22 PM

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

@austin-denoble austin-denoble merged commit dc46f52 into main Feb 20, 2025
32 checks passed
@austin-denoble austin-denoble deleted the adenoble/fix-embeddings-list branch February 20, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant