🐛 sha3@1.x produces node-gyp deprecation warnings and/or build error on install

[canterberry]

Reported in #32 for Node.js 12.7.0 on Mac OS X.

Confirmed deprecation warnings on Linux build environment with Node.js 12.4.0, 12.5.0, 12.6.0, and 12.7.0.
Confirmed build failure on Linux build environment with Node.js 12.3.0.

Upgrading to v2.x is not an option for most use cases because the project(s) do not use the sha3 library directly, but as a transitive dependency with a fuzzy version selector for sha3@1.x, for which a forced resolution of sha3@2.x will not resolve.

[canterberry]

Deprecation warnings in one version of Node.js indicate an imminent build error in a subsequent version. In some environments, warnings are treated as errors (e.g: the C compiler -Wall option), so a deprecation warning will already trigger a build error.

Two things should happen:

1. The Travis CI build for this repo should fail if any deprecation warnings are emitted.
2. All current deprecation warnings should be fixed.

💡 Note: Only the latest versions of the currently supported Node.js releases are officially supported by this library. Thus, Node.js 12.3.0 is not supported and is not in scope for this issue.

[canterberry]

One warning appears to be caused by a newly introduced C++17 feature "over-aligned allocation" recently in May 2019:

../src/addon.cpp: In static member function ‘static Nan::NAN_METHOD_RETURN_TYPE SHA3Hash::New(Nan::NAN_METHOD_ARGS_TYPE)’:
../src/addon.cpp:49:23: warning: ‘new’ of type ‘SHA3Hash’ with extended alignment 32 [-Waligned-new=]
    obj = new SHA3Hash();
                       ^
../src/addon.cpp:49:23: note: uses ‘void* operator new(std::size_t)’, which does not have an alignment parameter
../src/addon.cpp:49:23: note: use ‘-faligned-new’ to enable C++17 over-aligned new support

The other appears to be a revision to the V8 API:

../src/addon.cpp: In static member function ‘static void SHA3Hash::Init(Nan::ADDON_REGISTER_FUNCTION_ARGS_TYPE)’:
../src/addon.cpp:83:27: warning: ‘bool v8::Object::Set(v8::Local<v8::Value>, v8::Local<v8::Value>)’ is deprecated: Use maybe version [-Wdeprecated-declarations]
   target->Set(className, f);
                           ^

This is not my area of expertise, so I'd like to solicit the assistance of a seasoned C/C++ and/or Node.js add-ons developer to review and/or fix these warnings.

[canterberry]

The Node.js add-on examples follow the same constructor pattern for which the first (over-aligned new) warning applies. Given this warning is for what seems like a very rudimentary operation (i.e: calling a default constructor of a C++ object with no arguments), I'm surprised to have such difficulty in finding answers to how to address the warning.

[knoxcard2]

I am having this problem as well...

[mistersandman]

The build fails for Node.js version 12.3.0 due to a regression in Node.js itself, which was fixed in 12.3.1 (nodejs/node#27804).

The V8 API warning is due to the deprecation of a function, which was removed in Node.js 13, turning this warning into a build failure for version 13 and onwards. PR #68 provides a fix for this.

The alignment warning points out a bug that is fixed with PR #69.

[canterberry]

Fixed in #68 and #69.