Fix a bunch of things #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiLuJe
commented
Dec 28, 2017
ArtifactPower.lua
Outdated
| DUNGEON_TABLE[map].apTier[4] = 465 -- 10-14 | ||
| DUNGEON_TABLE[map].apTier[5] = 725 -- 15-19 | ||
| DUNGEON_TABLE[map].apTier[6] = 1025 -- 20-25 | ||
| DUNGEON_TABLE[map].apBonus = 50 -- 10+ |
There was a problem hiding this comment.
AFAICT, it's always the same amount, even at 15+ or 20+
NiLuJe
commented
Dec 28, 2017
|
|
||
| if amount < 10 then | ||
| return string.format('%.2f', amount) .. ' ' .. IMP[power] | ||
| return string.format('%.2f', amount) .. ' ' .. SI[power] |
There was a problem hiding this comment.
EU here, so I tend to prefer SI over IMP ;p.
NiLuJe
commented
Dec 28, 2017
| return string.format('%.2f', amount) .. ' ' .. SI[power] | ||
| else | ||
| return math.floor(amount) .. ' ' .. IMP[power] | ||
| return string.format('%.1f', amount) .. ' ' .. SI[power] |
There was a problem hiding this comment.
Seems relevant with current amounts
NiLuJe
commented
Dec 28, 2017
Communications.lua
Outdated
|
|
||
| if id then | ||
| local link, keyLevel = e.CreateKeyLink(id), e.UnitKeyLevel(id) | ||
| if keyLevel >= e.GetMinKeyLevel() then |
There was a problem hiding this comment.
The MinKeyLevel stuff was removed a few commits ago
NiLuJe
commented
Dec 28, 2017
Frame.lua
Outdated
| astralMouseOver:ClearAllPoints() | ||
| astralMouseOver:SetPoint('TOPLEFT', self, 'CENTER', -85, 0) | ||
| astralMouseOver:SetText(e.MapApText(e.UnitMapID(self.unitID), e.UnitKeyLevel(self.unitID))) | ||
| if AstralKeysSettings.frameOptions.list == 'guild' then |
NiLuJe
commented
Dec 28, 2017
Tables.lua
Outdated
| local name | ||
| local name, online | ||
| if e.FrameListShown() == 'guild' then | ||
| for i = 1, select(2, GetNumGuildMembers()) do |
There was a problem hiding this comment.
That only returns the number of online guild members, which ends up restricting the amount of people we loop over and query w/ GetGuildRosterInfo(), so we end up an incomplete dataset.
Instead, loop over every guild member, and trust GetGuildRosterInfo()'s online flag.
NB: May still be incomplete when a guild has over 1k members.
|
Rebased |
NiLuJe
force-pushed
the
master
branch
2 times, most recently
from
7ec3a7f to
42a8bea
Compare
|
Rebased |
|
Rebased |
Cache AP calculation w/ AK increase (not that this matters anymore) Map AP calculations (w/ proper 'bonus' token amounts) A bunch of extra whitespace/indent tweaks because I'm a bit OCD w/ these things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache AP calculation w/ AK increase (not that this matters anymore)
Map AP calculations (w/ proper 'bonus' token amounts)
Key announcements (broke in 2.0.0)(Fixed in 2.1.01/02)Map mouseover info in Friend tab(Fixed in 2.1.01/02)Show offline filter(Fixed in 2.1.01/02)A bunch of extra whitespace/indent tweaks because I'm a bit OCD w/ these
things