v0.10 offsetGet in conflict with getComponent

[solcik]

Hello,

thank you very much for v0.10.
I tried it right away in my project and found a lot of these errors.

 ------ ------------------------------------------------------------------------------
  Line   src/....php
 ------ ------------------------------------------------------------------------------
  43     Cannot access offset 'form' on Nette\ComponentModel\IComponent.
  59     Cannot access offset 'form' on Nette\ComponentModel\IComponent.
  86     Cannot access offset 'price' on Nette\ComponentModel\IComponent.
  87     Access to an undefined property Nette\ComponentModel\IComponent::$onSuccess.
 ------ ------------------------------------------------------------------------------

These were not shown in 0.9 and I think that conflict is between new handling of offsetGet and current dynamicReturnType for getComponent().

https://github.com/phpstan/phpstan-nette/blob/master/src/Type/Nette/ComponentModelDynamicReturnTypeExtension.php

https://github.com/nette/application/blob/v2.4.12/src/Application/UI/Component.php#L377-L386

If I change arrayAccess to get components to ->getComponent() method calls, errors go away.

[adaamz]

Yes, I already replaced my codebase with ->getComponent() calls.
There is no way (and i think there is no plan for that) how to handle dynamic return type extension for array access/set/unset/...

[novjan]

@CzechBoy Hey, do you have some script or something how to do this change automatically?

[adaamz]

@novjan I don't remember, but I replaced it with some regex.

[novjan]

Ok, thank you.
Anyway ... do you have some plans about it @ondrejmirtes ?

[ondrejmirtes]

I just had an idea how to implement this in an elegant way:

• phpstan/phpstan@41f478d
• c66d80c

Feel free to test it now, it will be released along with PHPStan 0.10.2 in a few days 😊

[novjan]

@ondrejmirtes Hi. It looks that it works only for first offset.

This is ok:

$this['form']->setDefaults([]);

This is ok:

$this['form-checkbox']->setDefaultValue(TRUE)

This is error:

$this['form']['checkbox']->setDefaultValue(TRUE)

[ondrejmirtes]

Can you show some more code, what about the factories? What $this['form'] refers to etc.

On Mon, 23 Jul 2018 at 10:10, novjan ***@***.***> wrote: @ondrejmirtes <https://github.com/ondrejmirtes> Hi. It looks that it works only for first offset. This is ok: $this['form']->setDefaults([]); This is ok: $this['form-checkbox']->setDefaultValue(TRUE) This is error: $this['form']['checkbox']->setDefaultValue(TRUE) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGZuBj2s0xftHQFOWCCritkxXarL8jYks5uJYT2gaJpZM4U3uCI> .

-- Ondřej Mirtes

[novjan]

@ondrejmirtes Small example:

protected function createComponentFormData()
{
	$isEdit = TRUE;
	$form = new \Nette\Application\UI\Form;
	$form->addText('text');

	if ($isEdit) {
		$form['form']->addRule($form::FILLED); // Call to an undefined method Nette\ComponentModel\IComponent::addRule().
	}

	$data = $form->addContainer('data');
	$data->addText('text2');

	$form['data']['text2']->setDefaultValue('text'); // Cannot access offset 'text2' on Nette\ComponentModel\IComponent.
}

[ondrejmirtes]

PHPStan has no way of knowing the type of $form['data']['text2']. It only works with createComponentFoo style factories.

[ondrejmirtes]

Use this pattern:

	$data = $form->addContainer('data');
	$text2 = $data->addText('text2');
	$text2->setDefaultValue('text');

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.