Skip to content

Fix #319 - Support ALGORITHM and LOCK options in ALTER TABLE statements #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Tithugues
Copy link
Contributor

@Tithugues Tithugues commented Apr 13, 2023

Attempt to fix issue #319.

Fixes: #319

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (91ed552) 97.08% compared to head (3ebc5dc) 97.04%.

Additional details and impacted files
@@             Coverage Diff              @@
##              5.8.x     #440      +/-   ##
============================================
- Coverage     97.08%   97.04%   -0.05%     
- Complexity     2186     2216      +30     
============================================
  Files            69       69              
  Lines          5008     5103      +95     
============================================
+ Hits           4862     4952      +90     
- Misses          146      151       +5     
Impacted Files Coverage Δ
src/Components/AlterOperation.php 100.00% <ø> (ø)
src/Tools/TestGenerator.php 0.00% <0.00%> (ø)

... and 49 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you !

@williamdes williamdes changed the title Support ALGORITHM and LOCK options in ALTER TABLE statements Fix #319 - Support ALGORITHM and LOCK options in ALTER TABLE statements Apr 14, 2023
williamdes added a commit that referenced this pull request Apr 14, 2023
Pull-request: #440

Signed-off-by: William Desportes <[email protected]>
@williamdes williamdes merged commit daae9fc into phpmyadmin:5.8.x Apr 14, 2023
williamdes added a commit that referenced this pull request Apr 14, 2023
Pull-request: #440

Signed-off-by: William Desportes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'",": Unrecognized alter operation' when altering table with ALGORITHM and LOCK clauses
2 participants