Differentiating between analyze and explain statements #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iifawzi <[email protected]>
iifawzi
commented
Nov 12, 2022
Codecov ReportBase: 95.63% // Head: 95.64% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #386 +/- ##
=========================================
Coverage 95.63% 95.64%
- Complexity 2141 2145 +4
=========================================
Files 67 67
Lines 4538 4548 +10
=========================================
+ Hits 4340 4350 +10
Misses 198 198
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
williamdes
reviewed
Nov 12, 2022
williamdes
reviewed
Nov 12, 2022
williamdes
reviewed
Nov 15, 2022
Signed-off-by: iifawzi <[email protected]>
williamdes
force-pushed
the
differentiate-analyze-explain
branch
from
14c814f to
a70d5e8
Compare
Signed-off-by: William Desportes <[email protected]>
williamdes
force-pushed
the
differentiate-analyze-explain
branch
from
a70d5e8 to
a9dbfe0
Compare
williamdes
added a commit
that referenced
this pull request
Nov 17, 2022
…ents Ref: phpmyadmin/phpmyadmin#17482 Pull-request: #386 Signed-off-by: William Desportes <[email protected]>
williamdes
added a commit
that referenced
this pull request
Nov 17, 2022
Pull-request: #386 Signed-off-by: William Desportes <[email protected]>
|
@iifawzi - thank you very much for this! I saw your test cases, can you please also add another test?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iifawzi [email protected]
Hi, this should fix phpmyadmin/phpmyadmin#17482 (comment)
Ref: phpmyadmin/phpmyadmin#17482 (comment).
We still need to implement the
EXPLAINstatement, but this might take place in a separate PR.