phpdoc use GroupKeyword for groups

[soyuka]

No description provided.

[codecov]

Codecov Report

Merging #325 (43600b2) into master (4823c4f) will decrease coverage by 3.98%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #325      +/-   ##
============================================
- Coverage     99.73%   95.75%   -3.99%     
- Complexity     1911     1978      +67     
============================================
  Files            63       65       +2     
  Lines          4601     4404     -197     
============================================
- Hits           4589     4217     -372     
- Misses           12      187     +175     

Impacted Files	Coverage Δ	Complexity Δ
src/Component.php	100.00% <ø> (ø)	3.00 <0.00> (ø)
src/Components/AlterOperation.php	100.00% <ø> (ø)	35.00 <0.00> (ø)
src/Components/Array2d.php	100.00% <ø> (ø)	15.00 <0.00> (ø)
src/Components/ArrayObj.php	100.00% <ø> (ø)	26.00 <0.00> (ø)
src/Components/CaseExpression.php	100.00% <ø> (ø)	54.00 <0.00> (+2.00)
src/Components/Condition.php	100.00% <ø> (ø)	29.00 <0.00> (ø)
src/Components/CreateDefinition.php	100.00% <ø> (ø)	43.00 <0.00> (ø)
src/Components/DataType.php	100.00% <ø> (ø)	17.00 <0.00> (ø)
src/Components/Expression.php	100.00% <ø> (ø)	90.00 <0.00> (ø)
src/Components/ExpressionArray.php	95.74% <ø> (-0.34%)	23.00 <0.00> (ø)
... and 120 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4823c4f...2d8013a. Read the comment docs.

[williamdes]

Hi @soyuka 🇫🇷
I do not know how you did find out that but it looks valid and

sql-parser/src/Parser.php

Lines 189 to 192 in 4823c4f

	'GROUP BY' => array(
	'class' => 'PhpMyAdmin\\SqlParser\\Components\\GroupKeyword',
	'field' => 'group',
	),

seems to confirm that

[soyuka]

I'm using psalm and the following code was flagged as erroneous as $statement->group was typed as OrderKeyword:

            $groups = [];
            foreach ($statement->order as $order) {
                $groups[] = new GroupKeyword($order->expr);
            }

            // Had to type this manually
            /** @var OrderKeyword[] */
            $statement->group = $groups;

Thanks for the quick merge!

[williamdes]

Very cool, we use psalm on the main project. Let me know if you find other issues