Partition by tables

[lapkritinis]

There is mistype which fails to parse partitioned by tables.
It joins "partition P0Engine INNODB" together. I have reported this issue to phpmyadmin.

[nijel]

Can you please include complete failing query?

[lapkritinis]

Proposed fix #176.

I have described issue here:
phpmyadmin/phpmyadmin#13725

Code below my fix also looks like a bug:

                if ($brackets === 0) {
                    $this->$field = trim($this->$field);
                    $field = null;
                }

I would change $this->$field to $field, but then $field=null doesn't make sense... Will leave for you to figure it out.

[lapkritinis]

I thought it works (it does copy partitioned table now), but resulting table is without partitions, so it needs deeper investigation.

[nijel]

What version do you use? I've added tests in 078509e and the do not indicate any problem...

[lapkritinis]

Latest available: 4.7.4
PHP 7.1.10

[lapkritinis]

Test you have added doesn't work in MySQL:

Static analysis:

1 errors were found during analysis.

Unrecognized statement type. (near "PARTITION" at position 209)
SQL query:

CREATE TABLE ts ( id int(11) DEFAULT NULL, purchased date DEFAULT NULL ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 PARTITION BY RANGE (YEAR(purchased)) SUBPARTITION BY HASH (TO_DAYS(purchased)) ( PARTITION p0 VALUES LESS THAN (1990) ( SUBPARTITION s0 ENGINE=InnoDB, SUBPARTITION s1 ENGINE=InnoDB ), PARTITION p1 VALUES LESS THAN (2000) ( SUBPARTITION s2 ENGINE=InnoDB, SUBPARTITION s3 ENGINE=InnoDB ), PARTITION p2 VALUES LESS THAN MAXVALUE ( SUBPARTITION s4 ENGINE=InnoDB, SUBPARTITION s5 ENGINE=InnoDB ) )

[nijel]

It works just fine for me on MariaDB 10.1.28. That's why I was asking what query is causing problems to you.