get rid of inet_aton and inet_ntoa #6944
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remicollet
changed the title
|
Ready for review and for net_ntoa and inet_aton |
nikic
reviewed
May 6, 2021
|
I'm also wondering if we should just have HAVE_INET_PTON/HAVE_INET_NTOP a hard build requirement. It's part of POSIX and supported by Linux, macOS and Windows at least. Are there any known systems that don't have it? Getting rid of that super dubious lock would be nice. |
Just in case anybody executes these test in parallel on PHP 7.4. (cherry picked from commit b4ffe54) Closes phpGH-6943.
remicollet
force-pushed
the
issue-inet-aton
branch
3 times, most recently
from
ad9e1da to
011b0be
Compare
nikic
reviewed
May 6, 2021
use inet_ntop iand inet_pton where available standardize buffer size
remicollet
force-pushed
the
issue-inet-aton
branch
from
011b0be to
4dc8b3c
Compare
Seems to be in glibc since 2.2.5... (so even in old RHEL-5) |
nikic
approved these changes
May 6, 2021
|
Merged in f9547f2 |
This was referenced May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some distribution may consider inet_aton, inet_ntoa, inet_addr... as deprecated, and their usage discouraged