Convert dom methods arginfo to PHP stubs #4721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodorejb
suggested changes
Sep 18, 2019
theodorejb
suggested changes
Sep 18, 2019
beberlei
changed the title
theodorejb
suggested changes
Sep 18, 2019
This was referenced Sep 22, 2019
Closed
|
Could you please rebase to resolve the merge conflicts? |
|
Niki also pointed me towards methods and return types, which in this case here need to be docblocks instead of real types. I will do the rebase as well. |
|
Test failures are legit. |
nikic
reviewed
Oct 29, 2019
ext/dom/dom.stub.php
Outdated
| public function registerPhpFunctions($restrict = null) {} | ||
| } | ||
|
|
||
| function dom_import_simplexml(SimpleXMLElement $node): ?DOMElement {} |
There was a problem hiding this comment.
Does this throw is a non-SimpleXMLElement is passed?
There was a problem hiding this comment.
No, it just emits a warning :-/ What is the approach in that case?
There was a problem hiding this comment.
I'd relax the type to object for now.
|
As a followup, we should kill the use of FALIAS in dom. Those are not actually aliases. |
|
@nikic yes killing FALIAS is on my todo list. Its confusing |
beberlei
force-pushed
the
dom-arginfo-stubs
branch
from
ac0db42 to
4253ca4
Compare
nikic
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.