Throw notice for plain wrapper fread/fwrite errors #4462
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like Windows mostly works. Apart from Windows-specific tests, we're missing |
|
TBH I wasn't aware we weren't doing that … but I never attempted reading from a directory fd either - so +1 from me; cannot imagine these being unhelpful. |
cmb69
reviewed
Jul 24, 2019
|
@nikic, see https://gist.github.com/cmb69/0dce91aa6886ef422f21975ba5dd5987. Instead of fixing fread_variation4-win32.phpt, just kill it and make fgetss_variation1-win32.phpt portable. |
|
@cmb69 Thanks, I've applied your patch now. |
|
AppVeyor CI failure is unrelated. |
|
Merged as 1cbcf0f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to what we do for socket ops, throw a notice for fread/fwrite errors on the plain file wrapper. The most common condition here is trying to write to a read-only stream or vice versa.
This continues the work from #4442. This will fix a number of bugs, including https://bugs.php.net/bug.php?id=69163 and https://bugs.php.net/bug.php?id=60671.
Not sure if this will work on Windows...
cc @bwoebi