Missing param in arginfo_pdostatement_setfetchmode #3803
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PDO::setFetchMode receives up to 3 params
|
Not sure on this one. It's an overloaded signature with different number of arguments depending on the first argument, we don't have a way to model that accurately. |
nikic
approved these changes
Feb 11, 2019
|
@nikic Is okay to merge or your comment is still relevant? Indeed this function has some various formats at userland. |
|
@carusogabriel It's okay to merge, I think. We have no way to make this signature full correct, but your version at least looks "more correct". |
|
Merged via ad75511. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening #3114 as master now is
PHP 8.0.