-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix arginfos of required arguments for some Reflection methods #3797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is still 👎 from me as it creates a BC break that is not fixable while supporting both PHP 7 and 8 (unless using conditional code). |
@Majkl578 You can, using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikic Fair. 👍
But please document this in upgrading guide as a BC break.
@carusogabriel Please combine this PR and #3798. Let's directly go to the correct variadic signature instead of doing this in two steps... |
@nikic Okay. Gonna fix a test that's breaking there as well |
When merging this, please add an UPGRADING note that mentions all of the old signatures, the new signatures, and the signatures that can be used to be compatible with both. |
Merged via 35db1cc. Thanks everyone for the discussion. |
Reopening #3443 against master branch (
PHP 8.0
now).This fixes: #74035 and #71416.
/cc @Ocramius @Majkl578