Skip to content

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Aug 10, 2025

@devnexen devnexen marked this pull request as ready for review August 10, 2025 20:00
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the global PDO constants that are not on the Pdo\Pgsql class.

@devnexen devnexen force-pushed the pdo_pgsql_rfc_85 branch 2 times, most recently from 7d941da to 303e4b9 Compare August 14, 2025 20:05
@devnexen devnexen closed this Aug 24, 2025
@arnaud-lb
Copy link
Member

@devnexen did you close this one because of #19526? I didn't handle the deprecation of the Pdo\Pgsql constants in my PR, only the global ones.

Should I merge my PR as-is, or shall I remove the deprecation of PDO::PGSQL_TRANSACTION* from it in favor of this PR?

@devnexen
Copy link
Member Author

Yes feel free to merge as-is no worries :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants