Fix GH-18898: SEGV zend_jit_op_array_hot with property hooks and preloading #18923
+131
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reloading Property hooks were not handled for JIT+trait+preloading. Split the existing functions that handle op arrays, and add iterations for property hooks.
iluuu1994
approved these changes
Jun 24, 2025
dstogov
approved these changes
Jun 30, 2025
There was a problem hiding this comment.
It would be simple to review this if you wouldn't mix the fix with refactoring.
Anyway, I don't know "property hooks" implementation well, and if @iluuu1994 agreed, I don't object.
|
Ok apologies, I will make sure to split such prs in multiple commits in the future: one for factoring out the code and one for the actual fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Property hooks were not handled for JIT+trait+preloading. Split the existing functions that handle op arrays, and add iterations for property hooks.
Only difference between the 2 tests is the JIT mode.