Fix failing soap tests on Windows #16084
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These failures are caused by the fix for GHSA-p99j-rfp4-xqvq. Since the two bug*.phpt tests don't need the "wsdl" query string, we use a `--CGI--` section instead. The two server*.phpt tests are harder to fix, since during evaluation of the `--SKIPIF--` section, the soap extension can be loaded, but it may not during evaluation of the `--FILE--` section. So for now, we skip these tests on Windows altogether.
nielsdos
reviewed
Sep 27, 2024
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Oct 1, 2024
These failures are caused by the fix for GHSA-p99j-rfp4-xqvq. Since the two bug*.phpt tests don't need the "wsdl" query string, and don't even need php-cgi, we just remove the `--GET--` section. The two server*.phpt tests are harder to fix, since during evaluation of the `--SKIPIF--` section, the soap extension can be loaded, but it may not during evaluation of the `--FILE--` section. So for now, we skip these tests on Windows altogether. Co-authored-by: Niels Dossche <[email protected]> Closes phpGH-16084.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These failures are caused by the fix for GHSA-p99j-rfp4-xqvq. Since the two bug*.phpt tests don't need the "wsdl" query string, we use a
--CGI--section instead. The two server*.phpt tests are harder to fix, since during evaluation of the--SKIPIF--section, the soap extension can be loaded, but it may not during evaluation of the--FILE--section. So for now, we skip these tests on Windows altogether.