Skip to content

Fix GH-15087 IntlChar::foldCase()'s $option is not optional #15091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix GH-15087 IntlChar::foldCase()'s $option is not optional #15091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82a76be
Fix GH-15087 IntlChar::foldCase()'s $option is not optional
cmb69 Jul 24, 2024
0ba36cd
Add missing `Z_PARAM_OPTIONAL`
cmb69 Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ext/intl/uchar/tests/gh15087.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
--TEST--
GH-15087 (IntlChar::foldCase()'s $option is not optional)
--EXTENSIONS--
intl
--FILE--
<?php
var_dump(IntlChar::foldCase('I'));
?>
--EXPECT--
string(1) "i"
3 changes: 2 additions & 1 deletion ext/intl/uchar/uchar.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,8 +392,9 @@ IC_METHOD(foldCase) {
zend_string *string_codepoint;
zend_long int_codepoint;

ZEND_PARSE_PARAMETERS_START(2, 2)
ZEND_PARSE_PARAMETERS_START(1, 2)
Z_PARAM_STR_OR_LONG(string_codepoint, int_codepoint)
Z_PARAM_OPTIONAL
Z_PARAM_LONG(options)
ZEND_PARSE_PARAMETERS_END();

Expand Down
Loading