Autotools: Refactor phpdbg POSIX Threads checks #14865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
petk
commented
Jul 7, 2024
petk
commented
- AS_VAR_IF, AS_VAR_APPEND used and CS synced
- Added one missing AC_MSG_RESULT to properly put the configure output log on each line
- AH_TEMPLATE used for HAVE_USERFAULTFD_WRITEFAULT to have help text on lesser places
- Redundant terminating semicolons removed
- Redundant PTHREADS_CHECK call removed as it is already done in configure.ac and before including SAPI M4 stubs
- Redundant CFLAGS and LIBS storing and restoring removed
- AS_VAR_IF, AS_VAR_APPEND used and CS synced - Added one missing AC_MSG_RESULT to properly put the configure output log on each line - AH_TEMPLATE used for HAVE_USERFAULTFD_WRITEFAULT to have help text on lesser places - Redundant terminating semicolons removed - Redundant PTHREADS_CHECK call removed as it is already done in configure.ac and before including SAPI M4 stubs - Redundant CFLAGS and LIBS storing and restoring removed
devnexen
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.