-
Notifications
You must be signed in to change notification settings - Fork 804
Synchronize manual with stubs for PHP 8.4 - part 5 #4206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should also get entries in versions.xml. I implemented this in 8.1 and above.
The backstory here is that people used to have custom serialization methods on these classes, but that broke when someone added the ZEND_ACC_NOT_SERIALIZABLE flag to these classes, making it impossible to serialize even for child classes. So I came up with this trick to unbreak backwards compatibility.
Co-authored-by: Niels Dossche <[email protected]>
Looks like it broke CI |
Yeah, I'm currently debugging what the issue is ^^ I'm also going to fixup the version in versions.xml in the same commit. |
Finally, I found it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
DOM class synopsis related changes.