Skip to content

Synchronize manual with stubs for PHP 8.4 - part 5 #4206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 30, 2024

Conversation

kocsismate
Copy link
Member

DOM class synopsis related changes.

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also get entries in versions.xml. I implemented this in 8.1 and above.
The backstory here is that people used to have custom serialization methods on these classes, but that broke when someone added the ZEND_ACC_NOT_SERIALIZABLE flag to these classes, making it impossible to serialize even for child classes. So I came up with this trick to unbreak backwards compatibility.

@nielsdos
Copy link
Member

XPointer evaluation failed: #xmlns(db=http://docbook.org/ns/docbook) xpointer(id('class.domnamespacenode')/db:refentry/db:refsect1[@ROLE='description']/descendant::db:methodsynopsis[@ROLE='DOMNameSpaceNode'])

Looks like it broke CI

@kocsismate
Copy link
Member Author

Looks like it broke CI

Yeah, I'm currently debugging what the issue is ^^ I'm also going to fixup the version in versions.xml in the same commit.

@kocsismate
Copy link
Member Author

Finally, I found it!

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kocsismate kocsismate merged commit d75a541 into php:master Nov 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants