Synchronize manual with stubs for PHP 8.4 - part 3 #4179
Conversation
reference/dir/directory.xml
Outdated
| <row> | ||
| <entry>8.4.0</entry> | ||
| <entry> | ||
| This class is now <literal>final</literal>. | ||
| </entry> | ||
| </row> |
There was a problem hiding this comment.
Incorrect this is part of https://wiki.php.net/rfc/directory-opaque-object which is PHP 8.5.
Please use a worktree and the stubs from PHP-8.4 to do these changes.
There was a problem hiding this comment.
Ah, I forgot that this was voted for PHP 8.5. Problem with using an older branch when generating the manual pages is that gen_stub.php usually receives improvements in master only, therefore I usually just disregard the stub changes that are not yet relevant.
There was a problem hiding this comment.
But you could use the stub files from PHP-8.4 with master gen_stub, no?
| <varlistentry xml:id="soapclient.props.--soap-fault"> | ||
| <varlistentry xml:id="soapclient.props.soap-fault"> |
There was a problem hiding this comment.
Not sure if those soap changes are correct, I'm pretty sure you are breaking links with this rn.
There was a problem hiding this comment.
AFAIR we had a discussion about this in an MR, and you preferred to omit the leading hyphens when generating these IDs. #3367 (comment) (I only found a small discussion with Haszi, but probably the main one happened when dealing with constants)
There was a problem hiding this comment.
Can you check if those IDs are used in a linken attribute or not? But in the same vein, you should remove the single hyphen from the constants below.
There was a problem hiding this comment.
I found no collision. In the same time, I removed the leading single hyphens.
No description provided.