-
Notifications
You must be signed in to change notification settings - Fork 813
abstract.xml Fix the error in the last example and CS #4149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The only thing I'm not sure about is whether one empty line is required between the hooks that contain the implementation. With an empty string, readability seems to be better. If we imagine that hooks are the same as methods, then, perhaps, it is better to leave one empty string between the "methods" :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the error only s/arguments/parameters?
Co-authored-by: Kamil Tekiela <[email protected]>
No, it's not the I will allow myself one quote there:
Try to think of arguments as actually non-named values that are sent to the method, and of parameters as an integral part of a function or method, and you will no longer be able to say that "optional arguments have been defined in the method" :) |
FYI https://phoenixnap.com/kb/sed-replace What I meant was: was swaping the word arguments for the word parameters the only meaningful change in this PR. I understand why you did it, I just wanted to make sure I didn't miss anything more important. |
Oh, yes, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The only thing I'm not sure about is whether one empty line is required between the hooks that contain the implementation. With an empty string, readability seems to be better.
If we imagine that hooks are the same as methods, then, perhaps, it is better to leave one empty string between the "methods" :)
In this case, it might be better to add one empty line between hooks without implementation