PHP 8.4: Document reflection changes #4037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drive-by fix for 8.1 ommision
arnaud-lb
approved these changes
Nov 11, 2024
| @@ -10,7 +10,7 @@ | |||
| <methodsynopsis role="ReflectionClass"> | |||
| <modifier>public</modifier> <type>void</type><methodname>ReflectionClass::resetAsLazyGhost</methodname> | |||
| <methodparam><type>object</type><parameter>object</parameter></methodparam> | |||
| <methodparam><type>callable</type><parameter>initializer</parameter></methodparam> | |||
There was a problem hiding this comment.
This one is a bug in the stub, unfortunately :( The parameter should have been called "initializer". I will fix this for 8.4.1.
There was a problem hiding this comment.
8.4.0 is not released yet, why wait for 8.4.1?
There was a problem hiding this comment.
I would like to, but can we still make changes to 8.4.0? As I understand, the current RC will be released as 8.4.0? Or am I mistaken?
There was a problem hiding this comment.
No that's not true. RC4 != final release.
Changes you make now will still make it in the final release.
There was a problem hiding this comment.
Oh, that's a good news. Thank you
Crell
approved these changes
Nov 11, 2024
Girgias
commented
Nov 12, 2024
This is being fixed in php-src
siwa32
added a commit
to siwa32/doc-ja
that referenced
this pull request
Dec 22, 2024
KentarouTakeda
added a commit
to php/doc-ja
that referenced
this pull request
Dec 23, 2024
* PHP 8.4: Document reflection changes を翻訳 php/doc-en#4037 * [PHP 8.4] Add class constant types for Reflection を翻訳 https://github.com/php/doc-en/pull/4244/files * インデント微調整 --------- Co-authored-by: 武田 憲太郎 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drive-by fix for 8.1 ommision