Skip to content

[PHP 8.4] Add manual for pg_result_memory_size() #3972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 30, 2024

Conversation

KentarouTakeda
Copy link
Contributor

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@KentarouTakeda
Copy link
Contributor Author

Thank you for your review!

Actually, I didn't know much about XML schema, so I was creating it by copying other pages without understanding what they meant. Your detailed explanation was very helpful!!

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Almost good (one minor issue below).

@KentarouTakeda KentarouTakeda requested a review from cmb69 October 30, 2024 15:05
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@cmb69 cmb69 merged commit b984d79 into php:master Oct 30, 2024
2 checks passed
@KentarouTakeda KentarouTakeda deleted the add-pg-result-memory-size branch October 30, 2024 15:40
Girgias added a commit that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants