Skip to content

Some fixes to the 8.4 migration guide #3910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Oct 23, 2024

No description provided.

@Girgias
Copy link
Member Author

Girgias commented Oct 23, 2024

@jimwins do you know why it is not picking up the DocBook 5.2 DTD?

@Girgias
Copy link
Member Author

Girgias commented Oct 23, 2024

I remember ... there is no DTD for 5.2, we need to set-up some sort of RelaxNG check rather than DTD...

@Girgias Girgias requested a review from TimWolla October 24, 2024 12:46
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While at it, please add the missing word "function" here:

and the <function>pow</function>.


LGTM other than these two remarks.

@Girgias Girgias merged commit b1b0396 into php:master Oct 24, 2024
2 checks passed
@Girgias Girgias deleted the 8.4-fixups branch October 24, 2024 14:36
@Girgias Girgias added this to the PHP 8.4 milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants