Skip to content

Add documentation for array_find RFC #3465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 4, 2024
Merged

Add documentation for array_find RFC #3465

merged 9 commits into from
Nov 4, 2024

Conversation

joshuaruesweg
Copy link
Member

This pull request adds the documentation for the array_find RFC which introduced the methods array_find, array_find_key, array_all and array_any.

@joshuaruesweg joshuaruesweg added this to the PHP 8.4 milestone Jun 20, 2024
Girgias
Girgias requested changes Aug 26, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only suggested some markup changes on the first function, but these should be mimicked on the other ones.

@TimWolla TimWolla mentioned this pull request Oct 15, 2024
Open
@joshuaruesweg joshuaruesweg requested a review from Girgias October 28, 2024 13:39
TimWolla
TimWolla reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some stylistic suggestions to be double checked by Girgias. The refpurpose should not end with a dot and not be overly technical

Girgias
Girgias reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more markup changes that I missed, also please use <simpara> instead of <para> wherever possible.

Girgias
Girgias approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Girgias Girgias merged commit 596c114 into php:master Nov 4, 2024
2 checks passed
This was referenced Nov 7, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimWolla TimWolla TimWolla approved these changes

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PHP 8.4
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuaruesweg @TimWolla @Girgias