Add missing libxml related constants #3388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't even realize we still expose XML_GLOBAL_NAMESPACE... Should be deprecated and eventually removed as nothing can take on that value. |
nielsdos
approved these changes
May 18, 2024
|
Actually, I just looked into deprecating XML_GLOBAL_NAMESPACE, and it looks like the constant will never really be compiled in because we require libxml2 2.9.0 at the minimum, which doesn't have it anymore. So I'm going to drop it from the manual and drop it from php-src. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing libxml related constants to ext/DOM and ext/libxml.
The references for these constants are: