Update FFI constant ID #3214
Merged
Update FFI constant ID #3214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The bash script: #! /bin/bash
\grep -lrE --include='*.xml' '"ffi-ffi\.constants\.biggest-alignment"' | xargs -d '\n' sed -i 's/"ffi-ffi\.constants\.biggest-alignment"/"ffi\.constants\.--biggest-alignment--"/g'
|
Girgias
reviewed
Feb 29, 2024
reference/ffi/ffi.xml
Outdated
| @@ -64,7 +64,7 @@ | |||
| <section xml:id="ffi-ffi.constants"> | |||
| &reftitle.constants; | |||
| <variablelist> | |||
| <varlistentry xml:id="ffi-ffi.constants.biggest-alignment"> | |||
| <varlistentry xml:id="ffi.constants.--biggest-alignment--"> | |||
There was a problem hiding this comment.
Ditto same as magic constants, also the ffi-ffi is think is used to distinguish between global FFI constants and constants on the FFI class
There was a problem hiding this comment.
This is a constant of the FFI class that's why it's in the classname.constants.constant-name format. Global (non-class) constant IDs are in the constant.constant-name format.
Looking at the stub and arginfo files, FFI doesn't seem to have any global (non-class) constants.
There was a problem hiding this comment.
Ah right, okay that makes sense
There was a problem hiding this comment.
And this is the script for the latest ID:
\grep -lrE --include='*.xml' '"ffi-ffi\.constants\.biggest-alignment"' | xargs -d '\n' sed -i 's/"ffi-ffi\.constants\.biggest-alignment"/"ffi\.constants\.biggest-alignment"/g'
Girgias
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update FFI constant ID to the "standard" class constant ID format.
Add bash script this update was made with so that it can be applied to translations as well.