Update magic constant IDs #3208
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 28, 2024 10:14
Update magic constant IDs to standard global constant ID format. Remove link to __TRAIT__.
This reverts commit 8a3b0a6.
|
The update script is as follows: #! /bin/bash
# replace <link> with <constant>
\grep -lrE --include='*.xml' '<link linkend="constant\.trait">__TRAIT__<\/link>' | xargs -d '\n' sed -i 's/<link linkend="constant\.trait">__TRAIT__<\/link>/<constant>__TRAIT__<\/constant>/g'
# rename IDs to standard global constant ID format
\grep -lrE --include='*.xml' '"constant\.line"' | xargs -d '\n' sed -i 's/"constant\.line"/"constant\.--line--"/g'
\grep -lrE --include='*.xml' '"constant\.file"' | xargs -d '\n' sed -i 's/"constant\.file"/"constant\.--file--"/g'
\grep -lrE --include='*.xml' '"constant\.dir"' | xargs -d '\n' sed -i 's/"constant\.dir"/"constant\.--dir--"/g'
\grep -lrE --include='*.xml' '"constant\.function"' | xargs -d '\n' sed -i 's/"constant\.function"/"constant\.--function--"/g'
\grep -lrE --include='*.xml' '"constant\.class"' | xargs -d '\n' sed -i 's/"constant\.class"/"constant\.--class--"/g'
\grep -lrE --include='*.xml' '"constant\.trait"' | xargs -d '\n' sed -i 's/"constant\.trait"/"constant\.--trait--"/g'
\grep -lrE --include='*.xml' '"constant\.method"' | xargs -d '\n' sed -i 's/"constant\.method"/"constant\.--method--"/g'
\grep -lrE --include='*.xml' '"constant\.namespace"' | xargs -d '\n' sed -i 's/"constant\.namespace"/"constant\.--namespace--"/g'
|
Girgias
requested changes
Feb 29, 2024
|
Closed as discussed for a different solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update magic constant IDs to "standard" global ID format so these can automatically be linked to by Phd.
I've also added a separate commit with the bash script that I made these changes with so that these can be applied to all translations without burdening the maintainers with manually doing these changes.