Skip to content

Remove COM constant values #3051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 3, 2024
Merged

Remove COM constant values #3051

merged 3 commits into from
Jan 3, 2024

Conversation

haszi
Copy link
Contributor

@haszi haszi commented Dec 30, 2023

Removed all the values and references to PHP 7.0 from the table as advised here and here.

@haszi haszi mentioned this pull request Dec 30, 2023
Merged
Girgias
Girgias reviewed Dec 31, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly having the whitespace removal as a seperate commit with [skip-revcheck] would be good

@haszi haszi force-pushed the Remove-COM-constant-values branch from 1d12b81 to 225b4d4 Compare December 31, 2023 19:24
@haszi haszi requested a review from Girgias December 31, 2023 19:43
Girgias
Girgias approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase and change the commit description of the last commit to be:

Add missing literal tags in VT_DATE description

?

@haszi haszi force-pushed the Remove-COM-constant-values branch from 105d259 to 0aa23d5 Compare January 3, 2024 16:14
@haszi haszi requested a review from Girgias January 3, 2024 16:16
Girgias
Girgias approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
And sorry for being so annoying

@Girgias Girgias merged commit f5a7cdd into php:master Jan 3, 2024
@haszi haszi deleted the Remove-COM-constant-values branch January 4, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haszi @Girgias