Skip to content

Add QuickStart with homebrew #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

WyriHaximus
Copy link
Contributor

@WyriHaximus WyriHaximus commented Jun 1, 2020

Add a quick start how to install PHP using homebrew on macOS/OX. Comes out as this:

Screenshot from 2020-06-10 16-00-25

Screenshot from 2020-06-10 16-00-17

@svpernova09
Copy link

\o/

@WyriHaximus WyriHaximus changed the title [WIP] Add QuickStart with homebrew Add QuickStart with homebrew Jun 1, 2020
@WyriHaximus WyriHaximus marked this pull request as ready for review June 1, 2020 16:56
@WyriHaximus WyriHaximus force-pushed the add-quickstart-with-homebrew branch 2 times, most recently from a640389 to e86e772 Compare June 1, 2020 21:18
@assertchris
Copy link

LGTM 🎉

@cmb69
Copy link
Member

cmb69 commented Jun 1, 2020

This looks somehow inconsistent. The PR says "The quickest way to install php on macOS is with homebrew:", but the second link refers to a section which claims that PHP would be bundled with macOS. If that's true, there would be no need to install at all.

Furthermore, the first link refers to a section which lists four package managers (homebrew being the last in the list). If the other package managers are no longer relevant, or inferior, maybe it would be better to change that page to clarify that, and also to link to brew.sh from there (and to leave the overview as is).

@WyriHaximus
Copy link
Contributor Author

@cmb69 tbh I have never heard a developer using mac using anything else than homebrew. Furthermore I would personally fould those two pages into one, or make the one with the list only about homebrew. Lastly, AFAIK, and @carusogabriel can confirm, the PHP version coming with MACOS is ancient and has certain issues.

@cmb69
Copy link
Member

cmb69 commented Jun 2, 2020

@WyriHaximus, then please feel free to fold these pages. :)

@carusogabriel
Copy link
Contributor

Lastly, AFAIK, and @carusogabriel can confirm, the PHP version coming with MACOS is ancient and has certain issues.

I can't, but I've been using Homebrew for a while to manage my PHP versions locally :)

@salathe
Copy link
Contributor

salathe commented Jun 2, 2020

the PHP version coming with MACOS is ancient...

Mine has 7.3.11, which I don't think qualifies as ancient at the time of writing.

If the other package managers are no longer relevant, or inferior, maybe it would be better to change that page to clarify that, and also to link to brew.sh from there (and to leave the overview as is).

Agreed.

I have never heard a developer using mac using anything else than homebrew.

I have. While homebrew is indeed (from my experience) a very common option, it's not the only one used out there.

Furthermore I would personally fould those two pages into one, or make the one with the list only about homebrew.

No thanks, on both accounts. I have no problem, however, with putting homebrew at the top of the list of package providers (fixing the link to it), and removing any package providers that are are now obsolete (if any).

@WyriHaximus
Copy link
Contributor Author

the PHP version coming with MACOS is ancient...

Mine has 7.3.11, which I don't think qualifies as ancient at the time of writing.

Nice, that's not as bad as I thought.

If the other package managers are no longer relevant, or inferior, maybe it would be better to change that page to clarify that, and also to link to brew.sh from there (and to leave the overview as is).

Agreed.

Two of them seems to be not updated for a year, the otherone not sure

I have never heard a developer using mac using anything else than homebrew.

I have. While homebrew is indeed (from my experience) a very common option, it's not the only one used out there.

Anything else besides the ones listed on the packages page?

Furthermore I would personally fould those two pages into one, or make the one with the list only about homebrew.

No thanks, on both accounts. I have no problem, however, with putting homebrew at the top of the list of package providers (fixing the link to it), and removing any package providers that are are now obsolete (if any).

Might more make sense to move the quickstart to that page and list the others are alternatives.

@salathe
Copy link
Contributor

salathe commented Jun 10, 2020

Might more make sense to move the quickstart to that page and list the others are alternatives.

I think this would be a sensible approach.

@WyriHaximus WyriHaximus force-pushed the add-quickstart-with-homebrew branch from e86e772 to 5ecccdc Compare June 10, 2020 14:02
@WyriHaximus
Copy link
Contributor Author

Might more make sense to move the quickstart to that page and list the others are alternatives.

I think this would be a sensible approach.

Updated, the pages, and also the preview in the OP

@afilina
Copy link
Contributor

afilina commented Jan 7, 2021

LGTM.

@cmb69
Copy link
Member

cmb69 commented Jan 7, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants