Skip to content

Smaller code and docblock fixes #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 15, 2019
Merged

Smaller code and docblock fixes #973

merged 8 commits into from
Jun 15, 2019

Conversation

noplanman
Copy link
Member

  • No longer use fully qualified class names where appropriate.
  • Correct various typing issues in docblocks.
  • Update to use new scrutinizer engine.

@noplanman noplanman requested a review from a team June 14, 2019 07:31
@noplanman noplanman force-pushed the smaller_code_and_docblock_fixes branch from fe01d1a to b3f9dc4 Compare June 14, 2019 11:31
@noplanman noplanman force-pushed the smaller_code_and_docblock_fixes branch from b3f9dc4 to 4b38992 Compare June 14, 2019 11:39
akalongman
akalongman approved these changes Jun 15, 2019
View reviewed changes
Copy link
Member

@akalongman akalongman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains a lot of changes and I am not sure I reviewed everything but lets merge and see 🙂

@noplanman noplanman merged commit ba25843 into php-telegram-bot:develop Jun 15, 2019
@noplanman noplanman deleted the smaller_code_and_docblock_fixes branch June 15, 2019 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akalongman akalongman akalongman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noplanman @akalongman @YMEBilly5