Skip to content

Bot API 4.0 & 4.1 - Telegram Passport (without decryption helpers) #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 20, 2018

Conversation

noplanman
Copy link
Member

Add Telegram Passport.

@php-telegram-bot/developers
For the errors I've used an interface, like with InputMedia and InputMessageContent.
Does that make sense, or use an abstract class to extend from?

Also, I'm really not sure how best to test all this (hence WIP) 😕

Copy link

@oleksiisurnin oleksiisurnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. When released?

@noplanman
Copy link
Member Author

@1Ganso Have you tested this code?
If so, would you be able to share your experiences and possibly a short guide on how to set up a testing environment for me to test it?

@noplanman noplanman changed the title WIP - Bot API 4.0 - Telegram Passport WIP - Bot API 4.0 & 4.1 - Telegram Passport Aug 29, 2018
@noplanman noplanman mentioned this pull request Sep 7, 2018
7 tasks
@noplanman noplanman force-pushed the bot_api_4.0_passport branch from 1b83703 to 32afb85 Compare October 23, 2018 17:04
@noplanman noplanman changed the title WIP - Bot API 4.0 & 4.1 - Telegram Passport Bot API 4.0 & 4.1 - Telegram Passport (without decryption helpers) Dec 20, 2018
@noplanman
Copy link
Member Author

Merging this without any decryption helpers, which will I've almost finished developing, but will add in a separate PR.

@noplanman noplanman merged commit 64907d1 into php-telegram-bot:develop Dec 20, 2018
@noplanman noplanman deleted the bot_api_4.0_passport branch December 20, 2018 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants