#858 add chat action constants

[smoqadam]

#858 add chat action constants

[noplanman]

@smoqadam

...to prevent from future mistakes like typos.

Unless they are built-in 😁
Please correct this one.

[noplanman]

@php-telegram-bot/developers
Would we want these all in the Telegram class or a separate class Action that has just those constants in it, i.e.

class Action
{
    const TYPING            = 'typing';
    const UPLOAD_PHOTO      = 'upload_photo';
    const RECORD_VIDEO      = 'record_video';
    const UPLOAD_VIDEO      = 'upload_video';
    const RECORD_AUDIO      = 'record_audio';
    const UPLOAD_AUDIO      = 'upload_audio';
    const UPLOAD_DOCUMENT   = 'upload_document';
    const FIND_LOCATION     = 'find_location';
    const RECORD_VIDEO_NOTE = 'record_video_note';
    const UPLOAD_VIDEO_NOTE = 'upload_video_note';
}

We'd also have to decide what namespace to put them in.

[akalongman]

+1 for separate class

[smoqadam]

ChatAction class wouldn't be more meaningful?

class ChatAction
{
    /**
     * Typing chat action
     */
    const TYPING = 'typing';

    /**
     * Upload Photo chat action
     */
    const UPLOAD_PHOTO = 'upload_photo';

    /**
     * Record Video chat action
     */
    const RECORD_VIDEO = 'record_video';
    .....

usage

Request::sendChatAction([
    'chat_id' => $chat_id,
    'action'  => Longman\TelegramBot\ChatAction::TYPING,
]);

[noplanman]

ChatAction class wouldn't be more meaningful?

Absolutely! Thanks for the fixed PR 👍