Skip to content

Implement Telegram Games platform. #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 14, 2018

Conversation

noplanman
Copy link
Member

@noplanman noplanman commented Dec 27, 2017

Finally add the Telegram Games platform!

WIP because it needs to be tested first ❗️

Closes #726

@noplanman
Copy link
Member Author

Since nobody seems to have a game to test this, I think we just merge and wait for feedback from anybody who uses it down the line.

What do you guys think?
@php-telegram-bot/developers @chuv1 @Hitmare

@SirDerpington
Copy link

I'd like to test this but I guess I can't fetch it locally since I don't have the rights to do so?

Maybe you could indeed merge it and then let me update it to test it then?

@noplanman
Copy link
Member Author

@SirDerpington You should be able to just fetch it from my branch, it's public.

Are you familiar with git? You can add my repo as a remote and then check out the branch:

$ git remote add noplanman https://github.com/noplanman/php-telegram-bot
$ git checkout noplanman/726-games

or if you've simply used composer to fetch the project, you could just fetch my branch directly.
Change your composer.json to use my repo and get the correct branch, then simply composer install it to get it 👍

{
    "repositories": [
        {
            "type": "git",
            "url": "https://github.com/noplanman/php-telegram-bot"
        }
    ],
    "require": {
        "longman/telegram-bot": "dev-726-games"
    }
}

@noplanman
Copy link
Member Author

@SirDerpington Have you managed to do some testing on this?

@SirDerpington
Copy link

@noplanman Sorry, I've been working on something else the last two weeks. I think I can take a look at it next week.
It's stll on my todo list since we need that feature sooner or later!

Copy link
Member

@akalongman akalongman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should merge and after testing and user feedback we will improve this feature

@akalongman
Copy link
Member

@noplanman please update your branch with current

@SirDerpington did you found time for testing this feature?

@noplanman noplanman changed the title [WIP] Implement Telegram Games platform. Implement Telegram Games platform. May 10, 2018
@noplanman noplanman merged commit 6e12b42 into php-telegram-bot:develop Jul 14, 2018
@noplanman noplanman deleted the 726-games branch July 14, 2018 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants